Commit 383d2fc9 authored May 20, 2013 by Lars-Peter Clausen Committed by Greg Kroah-Hartman May 20, 2013

tty: nwpserial: Pass correct pointer to free_irq()



free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dbd2df85

drivers/tty/serial/nwpserial.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -199,7 +199,7 @@ static void nwpserial_shutdown(struct uart_port *port)
	dcr_write(up->dcr_host, UART_IER, up->ier);		dcr_write(up->dcr_host, UART_IER, up->ier);

	/* free irq */		/* free irq */
	free_irq(up->port.irq, port);		free_irq(up->port.irq, up);
	}		}

	static int nwpserial_verify_port(struct uart_port *port,		static int nwpserial_verify_port(struct uart_port *port,

Admin message