Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid" (38317f5c) · Commits · 戴 / test

This reverts commit . Turns out that commit is wrong. Host controllers are allowed to use Clear Feature HALT as means to sync data toggle between host and periperal. Cc: <stable@vger.kernel.org> Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com>

drivers/usb/dwc3/gadget.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1470,9 +1470,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)
		unsigned transfer_in_flight;
		unsigned started;

		if (dep->flags & DWC3_EP_STALL)
		return 0;

		if (dep->number > 1)
		trb = dwc3_ep_prev_trb(dep, dep->trb_enqueue);
		else
		@@ -1494,8 +1491,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)
		else
		dep->flags \|= DWC3_EP_STALL;
		} else {
		if (!(dep->flags & DWC3_EP_STALL))
		return 0;

		ret = dwc3_send_clear_stall_ep_cmd(dep);
		if (ret)

Admin message