Commit 38262c01 authored Nov 01, 2019 by Alexandru Ardelean Committed by Jonathan Cameron Nov 03, 2019

iio: imu: adis: assign read val in debugfs hook only if op successful



This was also caught by the `-Wmaybe-uninitialized` warning, which
(ironically as-is) it makes quite a lot of sense to do for this.

The code that actually calls this function will fail to copy on
the uninitialized value.   Hence, patch does not need to go into stable.

Fixes: 78026a6f ("iio:imu:adis: Add debugfs register access support")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 9b742763

drivers/iio/imu/adis.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -229,6 +229,7 @@ int adis_debugfs_reg_access(struct iio_dev *indio_dev,
		int ret;

		ret = adis_read_reg_16(adis, reg, &val16);
		if (ret == 0)
		*readval = val16;

		return ret;

Admin message