Commit 38137335 authored Oct 16, 2019 by Mark Rutland Committed by Will Deacon Oct 16, 2019

arm64: mm: fix inverted PAR_EL1.F check



When detecting a spurious EL1 translation fault, we have the CPU retry
the translation using an AT S1E1R instruction, and inspect PAR_EL1 to
determine if the fault was spurious.

When PAR_EL1.F == 0, the AT instruction successfully translated the
address without a fault, which implies the original fault was spurious.
However, in this case we return false and treat the original fault as if
it was not spurious.

Invert the return value so that we treat such a case as spurious.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 42f91093 ("arm64: mm: Ignore spurious translation faults taken from the kernel")
Tested-by: James Morse <james.morse@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will@kernel.org>

parent 29a0f5ad

arch/arm64/mm/fault.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -268,8 +268,12 @@ static bool __kprobes is_spurious_el1_translation_fault(unsigned long addr,
		par = read_sysreg(par_el1);
		local_irq_restore(flags);

		/*
		* If we now have a valid translation, treat the translation fault as
		* spurious.
		*/
		if (!(par & SYS_PAR_EL1_F))
		return false;
		return true;

		/*
		* If we got a different type of fault from the AT instruction,

Admin message