Commit 3803d672 authored Feb 02, 2020 by Trond Myklebust Committed by Anna Schumaker Feb 03, 2020

NFS: Use kmemdup_nul() in nfs_readdir_make_qstr()



The directory strings stored in the readdir cache may be used with
printk(), so it is better to ensure they are nul-terminated.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 114de382

fs/nfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -198,7 +198,7 @@ static
		int nfs_readdir_make_qstr(struct qstr string, const char name, unsigned int len)
		{
		string->len = len;
		string->name = kmemdup(name, len, GFP_KERNEL);
		string->name = kmemdup_nul(name, len, GFP_KERNEL);
		if (string->name == NULL)
		return -ENOMEM;
		/*

Admin message