Commit 37fe0660 authored Apr 23, 2013 by Vlad Yasevich Committed by David S. Miller Apr 25, 2013

net: fix address check in rtnl_fdb_del



Commit 6681712d
	vxlan: generalize forwarding tables

relaxed the address checks in rtnl_fdb_del() to use is_zero_ether_addr().
This allows users to add multicast addresses using the fdb API.  However,
the check in rtnl_fdb_del() still uses a more strict
is_valid_ether_addr() which rejects multicast addresses.  Thus it
is possible to add an fdb that can not be later removed.
Relax the check in rtnl_fdb_del() as well.

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a11fbba9

net/core/rtnetlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2192,7 +2192,7 @@ static int rtnl_fdb_del(struct sk_buff skb, struct nlmsghdr nlh)
		}

		addr = nla_data(tb[NDA_LLADDR]);
		if (!is_valid_ether_addr(addr)) {
		if (is_zero_ether_addr(addr)) {
		pr_info("PF_BRIDGE: RTM_DELNEIGH with invalid ether address\n");
		return -EINVAL;
		}

Admin message