Commit 37f01d64 authored Apr 24, 2007 by David Gibson Committed by Paul Mackerras Apr 24, 2007

[POWERPC] Abolish PHYS_FMT macro from arch/powerpc



32-bit powerpc systems define a macro, PHYS_FMT, giving a printf
format string fragment for displaying physical addresses, since most
32-bit powerpc platforms use 32-bit physical addresses but a few use
64-bit physical addresses.

This macro is used in exactly one place, a rare error message, where
we can solve the problem more simply by just unconditionally casting
the address up to 64-bit quantity before formatting it.

This patch does so, meaning that as we bring MMU definitions from
asm-ppc over to asm-powerpc, cleaning them up in the process, we don't
need to implement this ugly macro (which additionally has a very bad
name for something global).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 30686ba6

arch/powerpc/mm/pgtable_32.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -183,8 +183,8 @@ __ioremap(phys_addr_t addr, unsigned long size, unsigned long flags)
		* mem_init() sets high_memory so only do the check after that.
		*/
		if (mem_init_done && (p < virt_to_phys(high_memory))) {
		printk("__ioremap(): phys addr "PHYS_FMT" is RAM lr %p\n", p,
		__builtin_return_address(0));
		printk("__ioremap(): phys addr 0x%llx is RAM lr %p\n",
		(unsigned long long)p, __builtin_return_address(0));
		return NULL;
		}

Admin message