Commit 37ed3222 authored by Eric Sandeen's avatar Eric Sandeen Committed by Linus Torvalds
Browse files

[PATCH] JBD: 16T fixes 



These are a few places I've found in jbd that look like they may not be
16T-safe, or consistent with the use of unsigned longs for block
containers.  Problems here would be somewhat hard to hit, would require
journal blocks past the 8T boundary, which would not be terribly common.
Still, should fix.

(some of these have come from the ext4 work on jbd as well).

I think there's one more possibility that the wrap() function may not be
safe IF your last block in the journal butts right up against the 232 block
boundary, but that seems like a VERY remote possibility, and I'm not
worrying about it at this point.

Signed-off-by: default avatarEric Sandeen <esandeen@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent eee194e7

fs/jbd/journal.c

+3 −3
Original line number Diff line number Diff line
@@ -271,7 +271,7 @@ static void journal_kill_thread(journal_t *journal) 
int journal_write_metadata_buffer(transaction_t *transaction,

				  struct journal_head  *jh_in,

				  struct journal_head **jh_out,

				  int blocknr)

				  unsigned long blocknr)

{

	int need_copy_out = 0;

	int done_copy_out = 0;
@@ -696,7 +696,7 @@ fail: 
 *  @bdev: Block device on which to create the journal

 *  @fs_dev: Device which hold journalled filesystem for this journal.

 *  @start: Block nr Start of journal.

 *  @len:  Lenght of the journal in blocks.

 *  @len:  Length of the journal in blocks.

 *  @blocksize: blocksize of journalling device

 *  @returns: a newly created journal_t *

 *
@@ -820,7 +820,7 @@ static void journal_fail_superblock (journal_t *journal) 
static int journal_reset(journal_t *journal)

{

	journal_superblock_t *sb = journal->j_superblock;

	unsigned int first, last;

	unsigned long first, last;



	first = be32_to_cpu(sb->s_first);

	last = be32_to_cpu(sb->s_maxlen);

include/linux/jbd.h

+2 −2
Original line number Diff line number Diff line
@@ -732,7 +732,7 @@ struct journal_s 
	 */

	struct block_device	*j_dev;

	int			j_blocksize;

	unsigned int		j_blk_offset;

	unsigned long		j_blk_offset;



	/*

	 * Device which holds the client fs.  For internal journal this will be
@@ -866,7 +866,7 @@ extern int 
journal_write_metadata_buffer(transaction_t	  *transaction,

			      struct journal_head  *jh_in,

			      struct journal_head **jh_out,

			      int		   blocknr);

			      unsigned long	   blocknr);



/* Transaction locking */

extern void		__wait_on_journal (journal_t *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE