Commit 37e44bc5 authored Apr 27, 2010 by Steven Rostedt Committed by Steven Rostedt Apr 27, 2010

tracing: Fix sleep time function profiling



When sleep_time is off the function profiler ignores the time that a task
is scheduled out. When the task is scheduled out a timestamp is taken.
When the task is scheduled back in, the timestamp is compared to the
current time and the saved calltimes are adjusted accordingly.

But when stopping the function profiler, the sched switch hook that
does this adjustment was stopped before shutting down the tracer.
This allowed some tasks to not get their timestamps set when they
scheduled out. When the function profiler started again, this would
skew the times of the scheduler functions.

This patch moves the stopping of the sched switch to after the function
profiler is stopped. It also ignores zero set calltimes, which may
happen on start up.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent e330b3bc

kernel/trace/ftrace.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -666,6 +666,10 @@ static void profile_graph_return(struct ftrace_graph_ret *trace)
		if (!stat->hash \|\| !ftrace_profile_enabled)
		goto out;

		/* If the calltime was zero'd ignore it */
		if (!trace->calltime)
		goto out;

		calltime = trace->rettime - trace->calltime;

		if (!(trace_flags & TRACE_ITER_GRAPH_TIME)) {
		@@ -3357,11 +3361,11 @@ void unregister_ftrace_graph(void)
		goto out;

		ftrace_graph_active--;
		unregister_trace_sched_switch(ftrace_graph_probe_sched_switch);
		ftrace_graph_return = (trace_func_graph_ret_t)ftrace_stub;
		ftrace_graph_entry = ftrace_graph_entry_stub;
		ftrace_shutdown(FTRACE_STOP_FUNC_RET);
		unregister_pm_notifier(&ftrace_suspend_notifier);
		unregister_trace_sched_switch(ftrace_graph_probe_sched_switch);

		out:
		mutex_unlock(&ftrace_lock);

Admin message