Commit 37e1df8c authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

ASoC: dapm: handle probe deferrals 



This starts to handle probe deferrals on regulators and clocks
on the ASoC DAPM.

I came to this patch after audio stopped working on Ux500 ages
ago and I finally looked into it to see what is wrong. I had
messages like this in the console since a while back:

ab8500-codec.0: ASoC: Failed to request audioclk: -517
ab8500-codec.0: ASoC: Failed to create DAPM control audioclk
ab8500-codec.0: Failed to create new controls -12
snd-soc-mop500.0: ASoC: failed to instantiate card -12
snd-soc-mop500.0: Error: snd_soc_register_card failed (-12)!
snd-soc-mop500: probe of snd-soc-mop500.0 failed with error -12

Apparently because the widget table for the codec looks like
this (sound/soc/codecs/ab8500-codec.c):

static const struct snd_soc_dapm_widget ab8500_dapm_widgets[] = {

        /* Clocks */
        SND_SOC_DAPM_CLOCK_SUPPLY("audioclk"),

        /* Regulators */
        SND_SOC_DAPM_REGULATOR_SUPPLY("V-AUD", 0, 0),
        SND_SOC_DAPM_REGULATOR_SUPPLY("V-AMIC1", 0, 0),
        SND_SOC_DAPM_REGULATOR_SUPPLY("V-AMIC2", 0, 0),
        SND_SOC_DAPM_REGULATOR_SUPPLY("V-DMIC", 0, 0),

So when we call snd_soc_register_codec() and any of these widgets
get a deferred probe we do not get an -EPROBE_DEFER (-517) back as
we should and instead we just fail. Apparently the code assumes
that clocks and regulators must be available at this point and
not defer.

After this patch it rather looks like this:

ab8500-codec.0: Failed to create new controls -517
snd-soc-mop500.0: ASoC: failed to instantiate card -517
snd-soc-mop500.0: Error: snd_soc_register_card failed (-517)!
(...)
abx500-clk.0: registered clocks for ab850x
snd-soc-mop500.0: ab8500-codec-dai.0 <-> ux500-msp-i2s.1 mapping ok
snd-soc-mop500.0: ab8500-codec-dai.1 <-> ux500-msp-i2s.3 mapping ok

I'm pretty happy about the patch as it it, but I'm a bit
uncertain on how to proceed: there are a lot of users of the
external functions snd_soc_dapm_new_control() (111 sites)
and that will now return an occassional error pointer, which
is not handled in the calling sites.

I want an indication from the maintainers whether I should just
go in and augment all these call sites, or if deferred probe
is frowned upon when it leads to this much overhead.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5de5b74

sound/soc/soc-dapm.c

+42 −0
Original line number Diff line number Diff line
@@ -363,6 +363,10 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
				snd_soc_dapm_new_control_unlocked(widget->dapm,

				&template);

			kfree(name);

			if (IS_ERR(data->widget)) {

				ret = PTR_ERR(data->widget);

				goto err_data;

			}

			if (!data->widget) {

				ret = -ENOMEM;

				goto err_data;
@@ -397,6 +401,10 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
			data->widget = snd_soc_dapm_new_control_unlocked(

						widget->dapm, &template);

			kfree(name);

			if (IS_ERR(data->widget)) {

				ret = PTR_ERR(data->widget);

				goto err_data;

			}

			if (!data->widget) {

				ret = -ENOMEM;

				goto err_data;
@@ -3403,11 +3411,22 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, 


	mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);

	w = snd_soc_dapm_new_control_unlocked(dapm, widget);

	/* Do not nag about probe deferrals */

	if (IS_ERR(w)) {

		int ret = PTR_ERR(w);



		if (ret != -EPROBE_DEFER)

			dev_err(dapm->dev,

				"ASoC: Failed to create DAPM control %s (%d)\n",

				widget->name, ret);

		goto out_unlock;

	}

	if (!w)

		dev_err(dapm->dev,

			"ASoC: Failed to create DAPM control %s\n",

			widget->name);



out_unlock:

	mutex_unlock(&dapm->card->dapm_mutex);

	return w;

}
@@ -3430,6 +3449,8 @@ snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm, 
		w->regulator = devm_regulator_get(dapm->dev, w->name);

		if (IS_ERR(w->regulator)) {

			ret = PTR_ERR(w->regulator);

			if (ret == -EPROBE_DEFER)

				return ERR_PTR(ret);

			dev_err(dapm->dev, "ASoC: Failed to request %s: %d\n",

				w->name, ret);

			return NULL;
@@ -3448,6 +3469,8 @@ snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm, 
		w->clk = devm_clk_get(dapm->dev, w->name);

		if (IS_ERR(w->clk)) {

			ret = PTR_ERR(w->clk);

			if (ret == -EPROBE_DEFER)

				return ERR_PTR(ret);

			dev_err(dapm->dev, "ASoC: Failed to request %s: %d\n",

				w->name, ret);

			return NULL;
@@ -3566,6 +3589,16 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm, 
	mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_INIT);

	for (i = 0; i < num; i++) {

		w = snd_soc_dapm_new_control_unlocked(dapm, widget);

		if (IS_ERR(w)) {

			ret = PTR_ERR(w);

			/* Do not nag about probe deferrals */

			if (ret == -EPROBE_DEFER)

				break;

			dev_err(dapm->dev,

				"ASoC: Failed to create DAPM control %s (%d)\n",

				widget->name, ret);

			break;

		}

		if (!w) {

			dev_err(dapm->dev,

				"ASoC: Failed to create DAPM control %s\n",
@@ -3842,6 +3875,15 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, 
	dev_dbg(card->dev, "ASoC: adding %s widget\n", link_name);



	w = snd_soc_dapm_new_control_unlocked(&card->dapm, &template);

	if (IS_ERR(w)) {

		ret = PTR_ERR(w);

		/* Do not nag about probe deferrals */

		if (ret != -EPROBE_DEFER)

			dev_err(card->dev,

				"ASoC: Failed to create %s widget (%d)\n",

				link_name, ret);

		goto outfree_kcontrol_news;

	}

	if (!w) {

		dev_err(card->dev, "ASoC: Failed to create %s widget\n",

			link_name);

sound/soc/soc-topology.c

+9 −0
Original line number Diff line number Diff line
@@ -1556,6 +1556,15 @@ widget: 
		widget = snd_soc_dapm_new_control(dapm, &template);

	else

		widget = snd_soc_dapm_new_control_unlocked(dapm, &template);

	if (IS_ERR(widget)) {

		ret = PTR_ERR(widget);

		/* Do not nag about probe deferrals */

		if (ret != -EPROBE_DEFER)

			dev_err(tplg->dev,

				"ASoC: failed to create widget %s controls (%d)\n",

				w->name, ret);

		goto hdr_err;

	}

	if (widget == NULL) {

		dev_err(tplg->dev, "ASoC: failed to create widget %s controls\n",

			w->name);

CRA Git | Maintained and supported by SUSTech CRA and CCSE