Commit 37c0bbb3 authored Jul 30, 2019 by David Howells

afs: Fix off-by-one in afs_rename() expected data version calculation



When afs_rename() calculates the expected data version of the target
directory in a cross-directory rename, it doesn't increment it as it
should, so it always thinks that the target inode is unexpectedly modified
on the server.

Fixes: a58823ac ("afs: Fix application of status and callback to be under same lock")
Signed-off-by: David Howells <dhowells@redhat.com>

parent a6eed4ab

fs/afs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1804,7 +1804,7 @@ static int afs_rename(struct inode old_dir, struct dentry old_dentry,
		afs_end_vnode_operation(&fc);
		goto error_rehash;
		}
		new_data_version = new_dvnode->status.data_version;
		new_data_version = new_dvnode->status.data_version + 1;
		} else {
		new_data_version = orig_data_version;
		new_scb = &scb[0];

Admin message