ARM: orion: replace setup_irq() by request_irq() (37b146e3) · Commits · 戴 / test

request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by:

afzal mohammed <afzal.mohd.ma@gmail.com> Reviewed-by:

Andrew Lunn <andrew@lunn.ch> Signed-off-by:

Gregory CLEMENT <gregory.clement@bootlin.com>

arch/arm/plat-orion/time.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -177,12 +177,6 @@ static irqreturn_t orion_timer_interrupt(int irq, void *dev_id)
		return IRQ_HANDLED;
		}

		static struct irqaction orion_timer_irq = {
		.name = "orion_tick",
		.flags = IRQF_TIMER,
		.handler = orion_timer_interrupt
		};

		void __init
		orion_time_set_base(void __iomem *_timer_base)
		{
		@@ -236,7 +230,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask,
		/*
		* Setup clockevent timer (interrupt-driven).
		*/
		setup_irq(irq, &orion_timer_irq);
		if (request_irq(irq, orion_timer_interrupt, IRQF_TIMER, "orion_tick",
		NULL))
		pr_err("Failed to request irq %u (orion_tick)\n", irq);
		orion_clkevt.cpumask = cpumask_of(0);
		clockevents_config_and_register(&orion_clkevt, tclk, 1, 0xfffffffe);
		}

Admin message