Commit 379e0be8 authored Feb 03, 2012 by Srivatsa S. Bhat Committed by Rafael J. Wysocki Feb 04, 2012

PM / Freezer: Thaw only kernel threads if freezing of kernel threads fails



If freezing of kernel threads fails, we are expected to automatically
thaw tasks in the error recovery path. However, at times, we encounter
situations in which we would like the automatic error recovery path
to thaw only the kernel threads, because we want to be able to do
some more cleanup before we thaw userspace. Something like:

error = freeze_kernel_threads();
if (error) {
	/* Do some cleanup */

	/* Only then thaw userspace tasks*/
	thaw_processes();
}

An example of such a situation is where we freeze/thaw filesystems
during suspend/hibernation. There, if freezing of kernel threads
fails, we would like to thaw the frozen filesystems before thawing
the userspace tasks.

So, modify freeze_kernel_threads() to thaw only kernel threads in
case of freezing failure. And change suspend_freeze_processes()
accordingly. (At the same time, let us also get rid of the rather
cryptic usage of the conditional operator (:?) in that function.)

[rjw: In fact, this patch fixes a regression introduced during the
 3.3 merge window, because without it thaw_processes() may be called
 before swsusp_free() in some situations and that may lead to massive
 memory allocation failures.]

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Nigel Cunningham <nigel@tuxonice.net>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent fe9161db

kernel/power/power.h

+22 −2

Original line number	Diff line number	Diff line
		@@ -231,8 +231,28 @@ extern int pm_test_level;
		#ifdef CONFIG_SUSPEND_FREEZER
		static inline int suspend_freeze_processes(void)
		{
		int error = freeze_processes();
		return error ? : freeze_kernel_threads();
		int error;

		error = freeze_processes();

		/*
		* freeze_processes() automatically thaws every task if freezing
		* fails. So we need not do anything extra upon error.
		*/
		if (error)
		goto Finish;

		error = freeze_kernel_threads();

		/*
		* freeze_kernel_threads() thaws only kernel threads upon freezing
		* failure. So we have to thaw the userspace tasks ourselves.
		*/
		if (error)
		thaw_processes();

		Finish:
		return error;
		}

		static inline void suspend_thaw_processes(void)

kernel/power/process.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -143,7 +143,10 @@ int freeze_processes(void)
		/**
		* freeze_kernel_threads - Make freezable kernel threads go to the refrigerator.
		*
		* On success, returns 0. On failure, -errno and system is fully thawed.
		* On success, returns 0. On failure, -errno and only the kernel threads are
		* thawed, so as to give a chance to the caller to do additional cleanups
		* (if any) before thawing the userspace tasks. So, it is the responsibility
		* of the caller to thaw the userspace tasks, when the time is right.
		*/
		int freeze_kernel_threads(void)
		{
		@@ -159,7 +162,7 @@ int freeze_kernel_threads(void)
		BUG_ON(in_atomic());

		if (error)
		thaw_processes();
		thaw_kernel_threads();
		return error;
		}

Admin message