openvswitch: Fix memory leak in ovs_vport_alloc() error path (3791b3f6) · Commits · 戴 / test

ovs_vport_alloc() bails out without freeing the memory 'vport' points to. Picked up by Coverity - CID 1230503. Fixes: ("openvswitch: Allow each vport to have an array of 'port_id's.") Signed-off-by:

Christoph Jaeger <cj@linux.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/openvswitch/vport.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -137,8 +137,10 @@ struct vport ovs_vport_alloc(int priv_size, const struct vport_ops ops,
		vport->ops = ops;
		INIT_HLIST_NODE(&vport->dp_hash_node);

		if (ovs_vport_set_upcall_portids(vport, parms->upcall_portids))
		if (ovs_vport_set_upcall_portids(vport, parms->upcall_portids)) {
		kfree(vport);
		return ERR_PTR(-EINVAL);
		}

		vport->percpu_stats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
		if (!vport->percpu_stats) {

Admin message