Commit 3782cc37 authored by jun qian's avatar jun qian Committed by Wolfram Sang
Browse files

i2c: tegra: replace spin_lock_irqsave with spin_lock in ISR



As you are already in ISR, it is unnecessary to call spin_lock_irqsave.

Signed-off-by: default avatarjun qian <hangdianqj@163.com>
Reviewed-by: default avatarDmitry Osipenko <digetx@gmail.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 4e7bca6f
Loading
Loading
Loading
Loading
+2 −3
Original line number Diff line number Diff line
@@ -608,11 +608,10 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id)
	u32 status;
	const u32 status_err = I2C_INT_NO_ACK | I2C_INT_ARBITRATION_LOST;
	struct tegra_i2c_dev *i2c_dev = dev_id;
	unsigned long flags;

	status = i2c_readl(i2c_dev, I2C_INT_STATUS);

	spin_lock_irqsave(&i2c_dev->xfer_lock, flags);
	spin_lock(&i2c_dev->xfer_lock);
	if (status == 0) {
		dev_warn(i2c_dev->dev, "irq status 0 %08x %08x %08x\n",
			 i2c_readl(i2c_dev, I2C_PACKET_TRANSFER_STATUS),
@@ -670,7 +669,7 @@ err:

	complete(&i2c_dev->msg_complete);
done:
	spin_unlock_irqrestore(&i2c_dev->xfer_lock, flags);
	spin_unlock(&i2c_dev->xfer_lock);
	return IRQ_HANDLED;
}