Commit 37815bf8 authored May 09, 2015 by Steven Rostedt Committed by Rusty Russell May 09, 2015

module: Call module notifier on failure after complete_formation()

The module notifier call chain for MODULE_STATE_COMING was moved up before
the parsing of args, into the complete_formation() call. But if the module failed
to load after that, the notifier call chain for MODULE_STATE_GOING was
never called and that prevented the users of those call chains from
cleaning up anything that was allocated.

Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com



Reported-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Fixes: 4982223e "module: set nx before marking module MODULE_STATE_COMING"
Cc: stable@vger.kernel.org # 3.16+
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 3e0283a5

kernel/module.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3370,6 +3370,9 @@ static int load_module(struct load_info info, const char __user uargs,
		module_bug_cleanup(mod);
		mutex_unlock(&module_mutex);

		blocking_notifier_call_chain(&module_notify_list,
		MODULE_STATE_GOING, mod);

		/* we can't deallocate the module until we clear memory protection */
		unset_module_init_ro_nx(mod);
		unset_module_core_ro_nx(mod);

Admin message