Unverified Commit 375e2c35 authored Sep 07, 2020 by Tuo Li Committed by Mark Brown Sep 11, 2020

ALSA: rockchip_i2s: fix a possible divide-by-zero bug in rockchip_i2s_hw_params()



The variable bclk_rate is checked in:
  if (bclk_rate && mclk_rate % bclk_rate)

This indicates that bclk_rate can be zero.
If so, a divide-by-zero bug will occur:
  div_bclk = mclk_rate / bclk_rate;

To fix this possible bug, the function returns -EINVAL when bclk_rate is
zero.

Signed-off-by: Tuo Li <tuoli96@outlook.com>
Link: https://lore.kernel.org/r/TY2PR04MB4029799E60A5BCAAD5B7B5BBB8280@TY2PR04MB4029.apcprd04.prod.outlook.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2a4b91a2

sound/soc/rockchip/rockchip_i2s.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -279,7 +279,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream,
		if (i2s->is_master_mode) {
		mclk_rate = clk_get_rate(i2s->mclk);
		bclk_rate = 2 * 32 * params_rate(params);
		if (bclk_rate && mclk_rate % bclk_rate)
		if (bclk_rate == 0 \|\| mclk_rate % bclk_rate)
		return -EINVAL;

		div_bclk = mclk_rate / bclk_rate;

Admin message