netfilter: xt_osf: Use continue to reduce indentation (372e2866) · Commits · 戴 / test

Invert logic in test to use continue. This routine already uses continue, use it a bit more to minimize > 80 column long lines and unnecessary indentation. No change in compiled object file. Other miscellanea: o Remove trailing whitespace o Realign arguments to multiline statement Signed-off-by:

Joe Perches <joe@perches.com> Acked-by:

Evgeniy Polyakov <zbr@ioremap.net> Signed-off-by:

Pablo Neira Ayuso <pablo@netfilter.org>

net/netfilter/xt_osf.c

+85 −84

Original line number	Diff line number	Diff line
		@@ -225,6 +225,8 @@ xt_osf_match_packet(const struct sk_buff skb, struct xt_action_param p)

		rcu_read_lock();
		list_for_each_entry_rcu(kf, &xt_osf_fingers[df], finger_entry) {
		int foptsize, optnum;

		f = &kf->finger;

		if (!(info->flags & XT_OSF_LOG) && strcmp(info->genre, f->genre))
		@@ -233,8 +235,8 @@ xt_osf_match_packet(const struct sk_buff skb, struct xt_action_param p)
		optp = _optp;
		fmatch = FMATCH_WRONG;

		if (totlen == f->ss && xt_osf_ttl(skb, info, f->ttl)) {
		int foptsize, optnum;
		if (totlen != f->ss \|\| !xt_osf_ttl(skb, info, f->ttl))
		continue;

		/*
		* Should not happen if userspace parser was written correctly.
		@@ -337,7 +339,6 @@ xt_osf_match_packet(const struct sk_buff skb, struct xt_action_param p)
		info->loglevel == XT_OSF_LOGLEVEL_FIRST)
		break;
		}
		}
		rcu_read_unlock();

		if (!fcount && (info->flags & XT_OSF_LOG))

Admin message