Commit 371ff93a authored Feb 26, 2014 by Alexander Gordeev Committed by Jens Axboe Mar 13, 2014

cciss: Fallback to MSI rather than to INTx if MSI-X failed



Currently the driver falls back to INTx mode when MSI-X
initialization failed. This is a suboptimal behaviour
for chips that also support MSI. This update changes that
behaviour and falls back to MSI mode in case MSI-X mode
initialization failed.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Mike Miller <mike.miller@hp.com>
Cc: iss_storagedev@hp.com
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 106fd892

drivers/block/cciss.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -4092,11 +4092,9 @@ static void cciss_interrupt_mode(ctlr_info_t *h)
		if (err > 0) {
		dev_warn(&h->pdev->dev,
		"only %d MSI-X vectors available\n", err);
		goto default_int_mode;
		} else {
		dev_warn(&h->pdev->dev,
		"MSI-X init failed %d\n", err);
		goto default_int_mode;
		}
		}
		if (pci_find_capability(h->pdev, PCI_CAP_ID_MSI)) {

Admin message