Commit 371fd7ba authored Oct 20, 2017 by Gustavo A. R. Silva Committed by Marc Kleine-Budde Nov 11, 2019

can: dev: can_restart(): remove unused code



Value assigned to variable err is overwritten at line
562: err = priv->do_set_mode(dev, CAN_MODE_START); before
it can be used.

Also, notice that this code has been there since 2014.

Addresses-Coverity-ID: 1227031
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 22820017

drivers/net/can/dev.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -553,10 +553,9 @@ static void can_restart(struct net_device *dev)

		/* send restart message upstream */
		skb = alloc_can_err_skb(dev, &cf);
		if (!skb) {
		err = -ENOMEM;
		if (!skb)
		goto restart;
		}

		cf->can_id \|= CAN_ERR_RESTARTED;

		netif_rx(skb);

Admin message