hwmon: (it87) Fix VID reading on IT8718F/IT8720F (371dc4a6) · Commits · 戴 / test

Comparing apples to bananas doesn't seem right. Consistently use the chips enum for chip type comparisons, to avoid such bugs in the future. The bug has been there since support for the IT8718F was added, so VID never worked for this chip nor for the similar IT8720F. Signed-off-by:

Jean Delvare <khali@linux-fr.org>

drivers/hwmon/it87.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1028,12 +1028,11 @@ static int __init it87_find(unsigned short *address,
		chip_type, *address, sio_data->revision);

		/* Read GPIO config and VID value from LDN 7 (GPIO) */
		if (chip_type != IT8705F_DEVID) {
		if (sio_data->type != it87) {
		int reg;

		superio_select(GPIO);
		if ((chip_type == it8718) \|\|
		(chip_type == it8720))
		if (sio_data->type == it8718 \|\| sio_data->type == it8720)
		sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);

		reg = superio_inb(IT87_SIO_PINX2_REG);

Admin message