Commit 371975b0 authored by Jeremy Kerr's avatar Jeremy Kerr Committed by Joel Stanley
Browse files

fsi/core: Fix error paths on CFAM init 



Change d1dcd678 re-worked the struct fsi_slave initialisation in
fsi_slave_init, but introduced a few inconsitencies: the slave->dev is
now registered through cdev_device_add, but we may kfree() the device
out from underneath the cdev registration. We may also leave an IDA
allocated.

This change fixes the error paths, so that we kfree() only before the
device is registered with the core code. We also move the smode write to
before we start creating proper devices, as it's the most likely to
fail. We also remove the IDA-allocated minor on error, and properly
clean up the of_node.

Fixes: d1dcd678 ("fsi: Add cfam char devices")
Reported-by: default avatarLei YU <mine260309@gmail.com>
Tested-by: default avatarJohn Wang <wangzqbj@inspur.com>
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
Signed-off-by: default avatarJoel Stanley <joel@jms.id.au>
parent afd26118

drivers/fsi/fsi-core.c

+20 −12
Original line number Diff line number Diff line
@@ -1037,6 +1037,14 @@ static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id) 


	}



	rc = fsi_slave_set_smode(slave);

	if (rc) {

		dev_warn(&master->dev,

				"can't set smode on slave:%02x:%02x %d\n",

				link, id, rc);

		goto err_free;

	}



	/* Allocate a minor in the FSI space */

	rc = __fsi_get_new_minor(slave, fsi_dev_cfam, &slave->dev.devt,

				 &slave->cdev_idx);
@@ -1048,17 +1056,14 @@ static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id) 
	rc = cdev_device_add(&slave->cdev, &slave->dev);

	if (rc) {

		dev_err(&slave->dev, "Error %d creating slave device\n", rc);

		goto err_free;

		goto err_free_ida;

	}



	rc = fsi_slave_set_smode(slave);

	if (rc) {

		dev_warn(&master->dev,

				"can't set smode on slave:%02x:%02x %d\n",

				link, id, rc);

		kfree(slave);

		return -ENODEV;

	}

	/* Now that we have the cdev registered with the core, any fatal

	 * failures beyond this point will need to clean up through

	 * cdev_device_del(). Fortunately though, nothing past here is fatal.

	 */



	if (master->link_config)

		master->link_config(master, link,

				    slave->t_send_delay,
@@ -1075,10 +1080,13 @@ static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id) 
		dev_dbg(&master->dev, "failed during slave scan with: %d\n",

				rc);



	return rc;

	return 0;



err_free_ida:

	fsi_free_minor(slave->dev.devt);

err_free:

	put_device(&slave->dev);

	of_node_put(slave->dev.of_node);

	kfree(slave);

	return rc;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE