Commit 3704432f authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: refactor info mask and ext_info attribute creation. 



Introduce an enum to specify whether the attribute is separate or
shared.

Factor out the bitmap handling for loop into a separate function.

Tidy up error handling and add a NULL assignment to squish a false
positive warning from GCC.

Change ext_info shared type from boolean to enum and update in all
drivers.

Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Reviewed-by: default avatarLars-Peter Clausen <lars@metafoo.de>
parent 9761696f

drivers/iio/dac/ad5064.c

+2 −1
Original line number Diff line number Diff line
@@ -285,8 +285,9 @@ static const struct iio_chan_spec_ext_info ad5064_ext_info[] = { 
		.name = "powerdown",

		.read = ad5064_read_dac_powerdown,

		.write = ad5064_write_dac_powerdown,

		.shared = IIO_SEPARATE,

	},

	IIO_ENUM("powerdown_mode", false, &ad5064_powerdown_mode_enum),

	IIO_ENUM("powerdown_mode", IIO_SEPARATE, &ad5064_powerdown_mode_enum),

	IIO_ENUM_AVAILABLE("powerdown_mode", &ad5064_powerdown_mode_enum),

	{ },

};

drivers/iio/dac/ad5380.c

+3 −1
Original line number Diff line number Diff line
@@ -247,8 +247,10 @@ static struct iio_chan_spec_ext_info ad5380_ext_info[] = { 
		.name = "powerdown",

		.read = ad5380_read_dac_powerdown,

		.write = ad5380_write_dac_powerdown,

		.shared = IIO_SEPARATE,

	},

	IIO_ENUM("powerdown_mode", true, &ad5380_powerdown_mode_enum),

	IIO_ENUM("powerdown_mode", IIO_SHARED_BY_TYPE,

		 &ad5380_powerdown_mode_enum),

	IIO_ENUM_AVAILABLE("powerdown_mode", &ad5380_powerdown_mode_enum),

	{ },

};

drivers/iio/dac/ad5446.c

+2 −1
Original line number Diff line number Diff line
@@ -132,8 +132,9 @@ static const struct iio_chan_spec_ext_info ad5446_ext_info_powerdown[] = { 
		.name = "powerdown",

		.read = ad5446_read_dac_powerdown,

		.write = ad5446_write_dac_powerdown,

		.shared = IIO_SEPARATE,

	},

	IIO_ENUM("powerdown_mode", false, &ad5446_powerdown_mode_enum),

	IIO_ENUM("powerdown_mode", IIO_SEPARATE, &ad5446_powerdown_mode_enum),

	IIO_ENUM_AVAILABLE("powerdown_mode", &ad5446_powerdown_mode_enum),

	{ },

};

drivers/iio/dac/ad5504.c

+3 −1
Original line number Diff line number Diff line
@@ -248,8 +248,10 @@ static const struct iio_chan_spec_ext_info ad5504_ext_info[] = { 
		.name = "powerdown",

		.read = ad5504_read_dac_powerdown,

		.write = ad5504_write_dac_powerdown,

		.shared = IIO_SEPARATE,

	},

	IIO_ENUM("powerdown_mode", true, &ad5504_powerdown_mode_enum),

	IIO_ENUM("powerdown_mode", IIO_SHARED_BY_TYPE,

		 &ad5504_powerdown_mode_enum),

	IIO_ENUM_AVAILABLE("powerdown_mode", &ad5504_powerdown_mode_enum),

	{ },

};

drivers/iio/dac/ad5624r_spi.c

+3 −1
Original line number Diff line number Diff line
@@ -163,8 +163,10 @@ static const struct iio_chan_spec_ext_info ad5624r_ext_info[] = { 
		.name = "powerdown",

		.read = ad5624r_read_dac_powerdown,

		.write = ad5624r_write_dac_powerdown,

		.shared = IIO_SEPARATE,

	},

	IIO_ENUM("powerdown_mode", true, &ad5624r_powerdown_mode_enum),

	IIO_ENUM("powerdown_mode", IIO_SHARED_BY_TYPE,

		 &ad5624r_powerdown_mode_enum),

	IIO_ENUM_AVAILABLE("powerdown_mode", &ad5624r_powerdown_mode_enum),

	{ },

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE