drivers/base: Platform notify needs to occur before drivers attach to the device (37022644) · Commits · 戴 / test

The platform_notify call for Arm and PPC architectures needs to be called before the driver attaches to the device. The problem only presents itself when hotplugging certain devices while the driver is already loaded. Signed-off-by:

Brian Walsh <brian@walsh.ws> Signed-off-by:

Andrew Morton <akpm@osdl.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

drivers/base/core.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -424,6 +424,10 @@ int device_add(struct device *dev)
		if ((error = kobject_add(&dev->kobj)))
		goto Error;

		/* notify platform of device entry */
		if (platform_notify)
		platform_notify(dev);

		dev->uevent_attr.attr.name = "uevent";
		dev->uevent_attr.attr.mode = S_IWUSR;
		if (dev->driver)
		@@ -488,10 +492,6 @@ int device_add(struct device *dev)
		class_intf->add_dev(dev, class_intf);
		up(&dev->class->sem);
		}

		/* notify platform of device entry */
		if (platform_notify)
		platform_notify(dev);
		Done:
		kfree(class_name);
		put_device(dev);

Admin message