drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2 (36f5f8a7) · Commits · 戴 / test

With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS will be disabled. However, the buggy code makes this actually not working as expected. - V2: clear all OD flags excpet DPMTABLE_OD_UPDATE_VDDC Signed-off-by:

Evan Quan <evan.quan@amd.com> Acked-by:

Alex Deucher <alexander.deucher@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct pp_hwmgr *hwmgr)
		return;
		}
		}

		if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
		data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
		data->need_update_dpm_table \|= DPMTABLE_OD_UPDATE_SCLK \| DPMTABLE_OD_UPDATE_MCLK;
		}
		}

		/**
		@@ -3683,6 +3678,10 @@ static int vega10_set_power_state_tasks(struct pp_hwmgr *hwmgr,

		vega10_update_avfs(hwmgr);

		/*
		* Clear all OD flags except DPMTABLE_OD_UPDATE_VDDC.
		* That will help to keep AVFS disabled.
		*/
		data->need_update_dpm_table &= DPMTABLE_OD_UPDATE_VDDC;

		return 0;

Admin message