Commit 36f30937 authored Feb 13, 2019 by Todd Kjos Committed by Greg Kroah-Hartman Feb 14, 2019

binder: fix sparse issue in binder_alloc_selftest.c

Fixes sparse issues reported by the kbuild test robot running
on https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git


char-misc-testing: bde4a19f ("binder: use userspace pointer as base
of buffer space")

Error output (drivers/android/binder_alloc_selftest.c):
sparse: warning: incorrect type in assignment (different address spaces)
sparse:    expected void *page_addr
sparse:    got void [noderef] <asn:1> *user_data
sparse: error: subtraction of different types can't work

Fixed by adding necessary "__user" tags.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ca5dc2d1

drivers/android/binder_alloc_selftest.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -102,10 +102,11 @@ static bool check_buffer_pages_allocated(struct binder_alloc *alloc,
		struct binder_buffer *buffer,
		size_t size)
		{
		void page_addr, end;
		void __user *page_addr;
		void __user *end;
		int page_index;

		end = (void *)PAGE_ALIGN((uintptr_t)buffer->user_data + size);
		end = (void __user *)PAGE_ALIGN((uintptr_t)buffer->user_data + size);
		page_addr = buffer->user_data;
		for (; page_addr < end; page_addr += PAGE_SIZE) {
		page_index = (page_addr - alloc->buffer) / PAGE_SIZE;

Admin message