[media] exynos4-is: Remove WARN_ON() from __fimc_pipeline_close() (36da6fcd) · Commits · 戴 / test

It's not a critical error to call __fimc_pipeline_close() with missing sensor subdev entity. Replace WARN_ON() with pr_warn() and return 0 instead of -EINVAL to fix control flow in some conditions. Signed-off-by:

Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:

Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:

Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/platform/exynos4-is/media-dev.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -220,15 +220,15 @@ static int __fimc_pipeline_close(struct exynos_media_pipeline *ep)
		struct fimc_pipeline *p = to_fimc_pipeline(ep);
		struct v4l2_subdev *sd = p ? p->subdevs[IDX_SENSOR] : NULL;
		struct fimc_md *fmd;
		int ret = 0;
		int ret;

		if (WARN_ON(sd == NULL))
		return -EINVAL;
		if (sd == NULL) {
		pr_warn("%s(): No sensor subdev\n", __func__);
		return 0;
		}

		if (p->subdevs[IDX_SENSOR]) {
		ret = fimc_pipeline_s_power(p, 0);
		fimc_md_set_camclk(sd, false);
		}

		fmd = entity_to_fimc_mdev(&sd->entity);

Admin message