Commit 36da5908 authored by Daniel Vetter's avatar Daniel Vetter Committed by Dave Airlie
Browse files

drm/gem: move drm_gem_object_handle_unreference_unlocked into drm_gem.c 



We have three callers of this function now and it's neither
performance critical nor really small. So an inline function feels
like overkill and unecessarily separates the different parts of the
code.

Since all callers of drm_gem_object_handle_free are now in drm_gem.c
we can make that static (and remove the unused EXPORT_SYMBOL). To
avoid a forward declaration move it (and drm_gem_object_free_bug) up a
bit.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 7106bf96

drivers/gpu/drm/drm_gem.c

+54 −35
Original line number Diff line number Diff line
@@ -201,6 +201,60 @@ drm_gem_remove_prime_handles(struct drm_gem_object *obj, struct drm_file *filp) 
	}

}



static void drm_gem_object_ref_bug(struct kref *list_kref)

{

	BUG();

}



/**

 * Called after the last handle to the object has been closed

 *

 * Removes any name for the object. Note that this must be

 * called before drm_gem_object_free or we'll be touching

 * freed memory

 */

static void drm_gem_object_handle_free(struct drm_gem_object *obj)

{

	struct drm_device *dev = obj->dev;



	/* Remove any name for this object */

	spin_lock(&dev->object_name_lock);

	if (obj->name) {

		idr_remove(&dev->object_name_idr, obj->name);

		obj->name = 0;

		spin_unlock(&dev->object_name_lock);

		/*

		 * The object name held a reference to this object, drop

		 * that now.

		*

		* This cannot be the last reference, since the handle holds one too.

		 */

		kref_put(&obj->refcount, drm_gem_object_ref_bug);

	} else

		spin_unlock(&dev->object_name_lock);



}



void

drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj)

{

	if (obj == NULL)

		return;



	if (atomic_read(&obj->handle_count) == 0)

		return;



	/*

	* Must bump handle count first as this may be the last

	* ref, in which case the object would disappear before we

	* checked for a name

	*/



	if (atomic_dec_and_test(&obj->handle_count))

		drm_gem_object_handle_free(obj);

	drm_gem_object_unreference_unlocked(obj);

}



/**

 * Removes the mapping from handle to filp for this object.

 */
@@ -656,41 +710,6 @@ drm_gem_object_free(struct kref *kref) 
}

EXPORT_SYMBOL(drm_gem_object_free);



static void drm_gem_object_ref_bug(struct kref *list_kref)

{

	BUG();

}



/**

 * Called after the last handle to the object has been closed

 *

 * Removes any name for the object. Note that this must be

 * called before drm_gem_object_free or we'll be touching

 * freed memory

 */

void drm_gem_object_handle_free(struct drm_gem_object *obj)

{

	struct drm_device *dev = obj->dev;



	/* Remove any name for this object */

	spin_lock(&dev->object_name_lock);

	if (obj->name) {

		idr_remove(&dev->object_name_idr, obj->name);

		obj->name = 0;

		spin_unlock(&dev->object_name_lock);

		/*

		 * The object name held a reference to this object, drop

		 * that now.

		*

		* This cannot be the last reference, since the handle holds one too.

		 */

		kref_put(&obj->refcount, drm_gem_object_ref_bug);

	} else

		spin_unlock(&dev->object_name_lock);



}

EXPORT_SYMBOL(drm_gem_object_handle_free);



void drm_gem_vm_open(struct vm_area_struct *vma)

{

	struct drm_gem_object *obj = vma->vm_private_data;

include/drm/drmP.h

+1 −20
Original line number Diff line number Diff line
@@ -1555,7 +1555,6 @@ int drm_gem_object_init(struct drm_device *dev, 
			struct drm_gem_object *obj, size_t size);

void drm_gem_private_object_init(struct drm_device *dev,

				 struct drm_gem_object *obj, size_t size);

void drm_gem_object_handle_free(struct drm_gem_object *obj);

void drm_gem_vm_open(struct vm_area_struct *vma);

void drm_gem_vm_close(struct vm_area_struct *vma);

int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
@@ -1602,25 +1601,7 @@ drm_gem_object_handle_reference(struct drm_gem_object *obj) 
	atomic_inc(&obj->handle_count);

}



static inline void

drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj)

{

	if (obj == NULL)

		return;



	if (atomic_read(&obj->handle_count) == 0)

		return;



	/*

	* Must bump handle count first as this may be the last

	* ref, in which case the object would disappear before we

	* checked for a name

	*/



	if (atomic_dec_and_test(&obj->handle_count))

		drm_gem_object_handle_free(obj);

	drm_gem_object_unreference_unlocked(obj);

}

void drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj);



void drm_gem_free_mmap_offset(struct drm_gem_object *obj);

int drm_gem_create_mmap_offset(struct drm_gem_object *obj);

CRA Git | Maintained and supported by SUSTech CRA and CCSE