dmaengine: coh901318: Fix a double lock bug in dma_tc_handle() (36d5d220) · Commits · 戴 / test

The caller is already holding the lock so this will deadlock. Fixes: ("DMAENGINE: COH 901 318 remove irq counting") Signed-off-by:

drivers/dma/coh901318.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1947,8 +1947,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc)
		return;
		}

		spin_lock(&cohc->lock);

		/*
		* When we reach this point, at least one queue item
		* should have been moved over from cohc->queue to
		@@ -1969,8 +1967,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc)
		if (coh901318_queue_start(cohc) == NULL)
		cohc->busy = 0;

		spin_unlock(&cohc->lock);

		/*
		* This tasklet will remove items from cohc->active
		* and thus terminates them.