dma: at_hdmac: remove unnecessary platform_set_drvdata() (36c6df50) · Commits · 戴 / test

The driver core clears the driver data to NULL after device_release or on probe failure, since commit (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:

Jingoo Han <jg1.han@samsung.com> Acked-by:

Nicolas Ferre <nicolas.ferre@atmel.com> Signed-off-by:

Vinod Koul <vinod.koul@intel.com>

drivers/dma/at_hdmac.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1570,7 +1570,6 @@ err_of_dma_controller_register:
		dma_async_device_unregister(&atdma->dma_common);
		dma_pool_destroy(atdma->dma_desc_pool);
		err_pool_create:
		platform_set_drvdata(pdev, NULL);
		free_irq(platform_get_irq(pdev, 0), atdma);
		err_irq:
		clk_disable(atdma->clk);
		@@ -1595,7 +1594,6 @@ static int at_dma_remove(struct platform_device *pdev)
		dma_async_device_unregister(&atdma->dma_common);

		dma_pool_destroy(atdma->dma_desc_pool);
		platform_set_drvdata(pdev, NULL);
		free_irq(platform_get_irq(pdev, 0), atdma);

		list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,

Admin message