Commit 369d21a7 authored Feb 09, 2019 by Coly Li Committed by Jens Axboe Feb 09, 2019

bcache: fix input overflow to writeback_delay



Sysfs file writeback_delay is used to configure dc->writeback_delay
which is type unsigned int. But bcache code uses sysfs_strtoul() to
convert the input string, therefore it might be overflowed if the input
value is too large. E.g. input value is 4294967296 but indeed 0 is
set to dc->writeback_delay.

This patch uses sysfs_strtoul_clamp() to convert the input string and
set the result value range in [0, UINT_MAX] to avoid such unsigned
integer overflow.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent f5c0b95d

drivers/md/bcache/sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -280,7 +280,7 @@ STORE(__cached_dev)
		sysfs_strtoul_bool(bypass_torture_test, dc->bypass_torture_test);
		sysfs_strtoul_bool(writeback_metadata, dc->writeback_metadata);
		sysfs_strtoul_bool(writeback_running, dc->writeback_running);
		d_strtoul(writeback_delay);
		sysfs_strtoul_clamp(writeback_delay, dc->writeback_delay, 0, UINT_MAX);

		sysfs_strtoul_clamp(writeback_percent, dc->writeback_percent,
		0, bch_cutoff_writeback);

Admin message