Commit 36999a5a authored Apr 19, 2009 by Tejun Heo Committed by Bartlomiej Zolnierkiewicz May 16, 2009

ide-tape: remove back-to-back REQUEST_SENSE detection



Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when
checking for back-to-back request sense issues but drive->pc can be
NULL and even when it's not NULL, it's not safe to dereference it once
the previous command is complete because pc could have been freed or
was on stack.  Kill back-to-back REQUEST_SENSE detection.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

parent 96c16743

drivers/ide/ide-tape.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -614,12 +614,6 @@ static ide_startstop_t ide_tape_issue_pc(ide_drive_t *drive,
		{
		idetape_tape_t *tape = drive->driver_data;

		if (drive->pc->c[0] == REQUEST_SENSE &&
		pc->c[0] == REQUEST_SENSE) {
		printk(KERN_ERR "ide-tape: possible ide-tape.c bug - "
		"Two request sense in serial were issued\n");
		}

		if (drive->failed_pc == NULL && pc->c[0] != REQUEST_SENSE)
		drive->failed_pc = pc;

Admin message