Commit 36996a1e authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req 



The structure element hisi_sas_devices.running_req to count how many
commands are active is in effect only ever written in the code, so remove
it.

Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent bb9abc4a

drivers/scsi/hisi_sas/hisi_sas.h

+0 −1
Original line number Diff line number Diff line
@@ -175,7 +175,6 @@ struct hisi_sas_device { 
	struct hisi_sas_dq	*dq;

	struct list_head	list;

	u64 attached_phy;

	atomic64_t running_req;

	enum sas_device_type	dev_type;

	int device_id;

	int sata_idx;

drivers/scsi/hisi_sas/hisi_sas_main.c

+0 −9
Original line number Diff line number Diff line
@@ -200,8 +200,6 @@ void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task, 


	if (task) {

		struct device *dev = hisi_hba->dev;

		struct domain_device *device = task->dev;

		struct hisi_sas_device *sas_dev = device->lldd_dev;



		if (!task->lldd_task)

			return;
@@ -213,9 +211,6 @@ void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task, 
				dma_unmap_sg(dev, task->scatter,

					     task->num_scatter,

					     task->data_dir);



		if (sas_dev)

			atomic64_dec(&sas_dev->running_req);

	}



	if (slot->buf)
@@ -431,8 +426,6 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq 
	spin_unlock_irqrestore(&task->task_state_lock, flags);



	dq->slot_prep = slot;



	atomic64_inc(&sas_dev->running_req);

	++(*pass);



	return 0;
@@ -1517,8 +1510,6 @@ hisi_sas_internal_abort_task_exec(struct hisi_hba *hisi_hba, int device_id, 


	dq->slot_prep = slot;



	atomic64_inc(&sas_dev->running_req);



	/* send abort command to the chip */

	hisi_hba->hw->start_delivery(dq);

	spin_unlock_irqrestore(&dq->lock, flags_dq);

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

+0 −3
Original line number Diff line number Diff line
@@ -1407,9 +1407,6 @@ static int slot_complete_v1_hw(struct hisi_hba *hisi_hba, 
	}



out:

	if (sas_dev)

		atomic64_dec(&sas_dev->running_req);



	hisi_sas_slot_task_free(hisi_hba, task, slot);

	sts = ts->stat;

CRA Git | Maintained and supported by SUSTech CRA and CCSE