Commit 3690739b authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Add static DAC/pin mapping for AD1986A codec 

AD1986A codec is a pretty old codec and has really many hidden
restrictions.  One of such is that each DAC is dedicated to certain
pin although there are possible connections.  Currently, the generic
parser tries to assign individual DACs as much as possible, and this
lead to two bad situations: connections where the sound actually
doesn't work, and connections conflicting other channels.

We may fix this by trying to find the best connections more harder,
but as of now, it's easier to give some hints for paired DAC/pin
connections and honor them if available, since such a hint is needed
only for specific codecs (right now only AD1986A, and there will be
unlikely any others in future).

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64971
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=66621


Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 7dca4bc6

sound/pci/hda/hda_generic.c

+22 −1
Original line number Diff line number Diff line
@@ -474,6 +474,20 @@ static void invalidate_nid_path(struct hda_codec *codec, int idx) 
	memset(path, 0, sizeof(*path));

}



/* return a DAC if paired to the given pin by codec driver */

static hda_nid_t get_preferred_dac(struct hda_codec *codec, hda_nid_t pin)

{

	struct hda_gen_spec *spec = codec->spec;

	const hda_nid_t *list = spec->preferred_dacs;



	if (!list)

		return 0;

	for (; *list; list += 2)

		if (*list == pin)

			return list[1];

	return 0;

}



/* look for an empty DAC slot */

static hda_nid_t look_for_dac(struct hda_codec *codec, hda_nid_t pin,

			      bool is_digital)
@@ -1192,6 +1206,13 @@ static int try_assign_dacs(struct hda_codec *codec, int num_outs, 
			continue;

		}



		dacs[i] = get_preferred_dac(codec, pin);

		if (dacs[i]) {

			if (is_dac_already_used(codec, dacs[i]))

				badness += bad->shared_primary;

		}



		if (!dacs[i])

			dacs[i] = look_for_dac(codec, pin, false);

		if (!dacs[i] && !i) {

			/* try to steal the DAC of surrounds for the front */

sound/pci/hda/hda_generic.h

+3 −0
Original line number Diff line number Diff line
@@ -249,6 +249,9 @@ struct hda_gen_spec { 
	const struct badness_table *main_out_badness;

	const struct badness_table *extra_out_badness;



	/* preferred pin/DAC pairs; an array of paired NIDs */

	const hda_nid_t *preferred_dacs;



	/* loopback mixing mode */

	bool aamix_mode;

sound/pci/hda/patch_analog.c

+10 −0
Original line number Diff line number Diff line
@@ -340,6 +340,14 @@ static int patch_ad1986a(struct hda_codec *codec) 
{

	int err;

	struct ad198x_spec *spec;

	static hda_nid_t preferred_pairs[] = {

		0x1a, 0x03,

		0x1b, 0x03,

		0x1c, 0x04,

		0x1d, 0x05,

		0x1e, 0x03,

		0

	};



	err = alloc_ad_spec(codec);

	if (err < 0)
@@ -360,6 +368,8 @@ static int patch_ad1986a(struct hda_codec *codec) 
	 * So, let's disable the shared stream.

	 */

	spec->gen.multiout.no_share_stream = 1;

	/* give fixed DAC/pin pairs */

	spec->gen.preferred_dacs = preferred_pairs;



	/* AD1986A can't manage the dynamic pin on/off smoothly */

	spec->gen.auto_mute_via_amp = 1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE