Commit 367dc658 authored Feb 01, 2018 by Geert Uytterhoeven Committed by David S. Miller Feb 01, 2018

net: bridge: Fix uninitialized error in br_fdb_sync_static()



With gcc-4.1.2.:

    net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’:
    net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this function

Indeed, if the list is empty, err will be uninitialized, and will be
propagated up as the function return value.

Fix this by preinitializing err to zero.

Fixes: eb793583 ("net: bridge: use rhashtable for fdbs")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9382fe71

net/bridge/br_fdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -993,7 +993,7 @@ int br_fdb_delete(struct ndmsg ndm, struct nlattr tb[],
		int br_fdb_sync_static(struct net_bridge br, struct net_bridge_port p)
		{
		struct net_bridge_fdb_entry f, tmp;
		int err;
		int err = 0;

		ASSERT_RTNL();

Admin message