Commit 36772092 authored by Paolo 'Blaisorblade' Giarrusso's avatar Paolo 'Blaisorblade' Giarrusso Committed by Linus Torvalds
Browse files

[PATCH] comments on locking of task->comm 



Add some comments about task->comm, to explain what it is near its definition
and provide some important pointers to its uses.

Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 291c4a75

fs/exec.c

+3 −1
Original line number Diff line number Diff line
@@ -869,9 +869,11 @@ int flush_old_exec(struct linux_binprm * bprm) 
	if (current->euid == current->uid && current->egid == current->gid)

		current->mm->dumpable = 1;

	name = bprm->filename;



	/* Copies the binary name from after last slash */

	for (i=0; (ch = *(name++)) != '\0';) {

		if (ch == '/')

			i = 0;

			i = 0; /* overwrite what we wrote */

		else

			if (i < (sizeof(tcomm) - 1))

				tcomm[i++] = ch;

include/linux/sched.h

+5 −2
Original line number Diff line number Diff line
@@ -578,7 +578,7 @@ struct task_struct { 
	unsigned long flags;	/* per process flags, defined below */

	unsigned long ptrace;



	int lock_depth;		/* Lock depth */

	int lock_depth;		/* BKL lock depth */



	int prio, static_prio;

	struct list_head run_list;
@@ -661,7 +661,10 @@ struct task_struct { 
	struct key *thread_keyring;	/* keyring private to this thread */

#endif

	int oomkilladj; /* OOM kill score adjustment (bit shift). */

	char comm[TASK_COMM_LEN];

	char comm[TASK_COMM_LEN]; /* executable name excluding path

				     - access with [gs]et_task_comm (which lock

				       it with task_lock())

				     - initialized normally by flush_old_exec */

/* file system info */

	int link_count, total_link_count;

/* ipc stuff */

CRA Git | Maintained and supported by SUSTech CRA and CCSE