Commit 364df0eb authored Jun 23, 2009 by Dimitri Sivanich Committed by Linus Torvalds Jun 23, 2009

mm: fix handling of pagesets for downed cpus



After downing/upping a cpu, an attempt to set
/proc/sys/vm/percpu_pagelist_fraction results in an oops in
percpu_pagelist_fraction_sysctl_handler().

If a processor is downed then we need to set the pageset pointer back to
the boot pageset.

Updates of the high water marks should not access pagesets of unpopulated
zones (those pointer go to the boot pagesets which would be no longer
functional if their size would be increased beyond zero).

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 01ff53f4

mm/page_alloc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -3026,7 +3026,7 @@ bad:
		if (dzone == zone)
		break;
		kfree(zone_pcp(dzone, cpu));
		zone_pcp(dzone, cpu) = NULL;
		zone_pcp(dzone, cpu) = &boot_pageset[cpu];
		}
		return -ENOMEM;
		}
		@@ -3041,7 +3041,7 @@ static inline void free_zone_pagesets(int cpu)
		/* Free per_cpu_pageset if it is slab allocated */
		if (pset != &boot_pageset[cpu])
		kfree(pset);
		zone_pcp(zone, cpu) = NULL;
		zone_pcp(zone, cpu) = &boot_pageset[cpu];
		}
		}

		@@ -4659,7 +4659,7 @@ int percpu_pagelist_fraction_sysctl_handler(ctl_table *table, int write,
		ret = proc_dointvec_minmax(table, write, file, buffer, length, ppos);
		if (!write \|\| (ret == -EINVAL))
		return ret;
		for_each_zone(zone) {
		for_each_populated_zone(zone) {
		for_each_online_cpu(cpu) {
		unsigned long high;
		high = zone->present_pages / percpu_pagelist_fraction;

Admin message