Commit 364c6bad authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

[NET]: Clean up skb_linearize 



The linearisation operation doesn't need to be super-optimised.  So we can
replace __skb_linearize with __pskb_pull_tail which does the same thing but
is more general.

Also, most users of skb_linearize end up testing whether the skb is linear
or not so it helps to make skb_linearize do just that.

Some callers of skb_linearize also use it to copy cloned data, so it's
useful to have a new function skb_linearize_cow to copy the data if it's
either non-linear or cloned.

Last but not least, I've removed the gfp argument since nobody uses it
anymore.  If it's ever needed we can easily add it back.

Misc bugs fixed by this patch:

* via-velocity error handling (also, no SG => no frags)

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 932ff279

drivers/block/aoe/aoenet.c

+1 −2
Original line number Diff line number Diff line
@@ -116,8 +116,7 @@ aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt, 
	skb = skb_share_check(skb, GFP_ATOMIC);

	if (skb == NULL)

		return 0;

	if (skb_is_nonlinear(skb))

	if (skb_linearize(skb, GFP_ATOMIC) < 0)

	if (skb_linearize(skb))

		goto exit;

	if (!is_aoe_netif(ifp))

		goto exit;

drivers/net/mv643xx_eth.c

+1 −1
Original line number Diff line number Diff line
@@ -1200,7 +1200,7 @@ static int mv643xx_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) 
	}



	if (has_tiny_unaligned_frags(skb)) {

		if ((skb_linearize(skb, GFP_ATOMIC) != 0)) {

		if (__skb_linearize(skb)) {

			stats->tx_dropped++;

			printk(KERN_DEBUG "%s: failed to linearize tiny "

					"unaligned fragment\n", dev->name);

drivers/net/via-velocity.c

+7 −3
Original line number Diff line number Diff line
@@ -1899,6 +1899,13 @@ static int velocity_xmit(struct sk_buff *skb, struct net_device *dev) 


	int pktlen = skb->len;



#ifdef VELOCITY_ZERO_COPY_SUPPORT

	if (skb_shinfo(skb)->nr_frags > 6 && __skb_linearize(skb)) {

		kfree_skb(skb);

		return 0;

	}

#endif



	spin_lock_irqsave(&vptr->lock, flags);



	index = vptr->td_curr[qnum];
@@ -1914,8 +1921,6 @@ static int velocity_xmit(struct sk_buff *skb, struct net_device *dev) 
	 */

	if (pktlen < ETH_ZLEN) {

		/* Cannot occur until ZC support */

		if(skb_linearize(skb, GFP_ATOMIC))

			return 0; 

		pktlen = ETH_ZLEN;

		memcpy(tdinfo->buf, skb->data, skb->len);

		memset(tdinfo->buf + skb->len, 0, ETH_ZLEN - skb->len);
@@ -1933,7 +1938,6 @@ static int velocity_xmit(struct sk_buff *skb, struct net_device *dev) 
		int nfrags = skb_shinfo(skb)->nr_frags;

		tdinfo->skb = skb;

		if (nfrags > 6) {

			skb_linearize(skb, GFP_ATOMIC);

			memcpy(tdinfo->buf, skb->data, skb->len);

			tdinfo->skb_dma[0] = tdinfo->buf_dma;

			td_ptr->tdesc0.pktsize =

include/linux/skbuff.h

+20 −4
Original line number Diff line number Diff line
@@ -1169,18 +1169,34 @@ static inline int skb_can_coalesce(struct sk_buff *skb, int i, 
	return 0;

}



static inline int __skb_linearize(struct sk_buff *skb)

{

	return __pskb_pull_tail(skb, skb->data_len) ? 0 : -ENOMEM;

}



/**

 *	skb_linearize - convert paged skb to linear one

 *	@skb: buffer to linarize

 *	@gfp: allocation mode

 *

 *	If there is no free memory -ENOMEM is returned, otherwise zero

 *	is returned and the old skb data released.

 */

extern int __skb_linearize(struct sk_buff *skb, gfp_t gfp);

static inline int skb_linearize(struct sk_buff *skb, gfp_t gfp)

static inline int skb_linearize(struct sk_buff *skb)

{

	return skb_is_nonlinear(skb) ? __skb_linearize(skb) : 0;

}



/**

 *	skb_linearize_cow - make sure skb is linear and writable

 *	@skb: buffer to process

 *

 *	If there is no free memory -ENOMEM is returned, otherwise zero

 *	is returned and the old skb data released.

 */

static inline int skb_linearize_cow(struct sk_buff *skb)

{

	return __skb_linearize(skb, gfp);

	return skb_is_nonlinear(skb) || skb_cloned(skb) ?

	       __skb_linearize(skb) : 0;

}



/**

net/core/dev.c

+2 −61
Original line number Diff line number Diff line
@@ -1222,64 +1222,6 @@ static inline int illegal_highdma(struct net_device *dev, struct sk_buff *skb) 
#define illegal_highdma(dev, skb)	(0)

#endif



/* Keep head the same: replace data */

int __skb_linearize(struct sk_buff *skb, gfp_t gfp_mask)

{

	unsigned int size;

	u8 *data;

	long offset;

	struct skb_shared_info *ninfo;

	int headerlen = skb->data - skb->head;

	int expand = (skb->tail + skb->data_len) - skb->end;



	if (skb_shared(skb))

		BUG();



	if (expand <= 0)

		expand = 0;



	size = skb->end - skb->head + expand;

	size = SKB_DATA_ALIGN(size);

	data = kmalloc(size + sizeof(struct skb_shared_info), gfp_mask);

	if (!data)

		return -ENOMEM;



	/* Copy entire thing */

	if (skb_copy_bits(skb, -headerlen, data, headerlen + skb->len))

		BUG();



	/* Set up shinfo */

	ninfo = (struct skb_shared_info*)(data + size);

	atomic_set(&ninfo->dataref, 1);

	ninfo->tso_size = skb_shinfo(skb)->tso_size;

	ninfo->tso_segs = skb_shinfo(skb)->tso_segs;

	ninfo->nr_frags = 0;

	ninfo->frag_list = NULL;



	/* Offset between the two in bytes */

	offset = data - skb->head;



	/* Free old data. */

	skb_release_data(skb);



	skb->head = data;

	skb->end  = data + size;



	/* Set up new pointers */

	skb->h.raw   += offset;

	skb->nh.raw  += offset;

	skb->mac.raw += offset;

	skb->tail    += offset;

	skb->data    += offset;



	/* We are no longer a clone, even if we were. */

	skb->cloned    = 0;



	skb->tail     += skb->data_len;

	skb->data_len  = 0;

	return 0;

}



#define HARD_TX_LOCK(dev, cpu) {			\

	if ((dev->features & NETIF_F_LLTX) == 0) {	\

		netif_tx_lock(dev);			\
@@ -1326,7 +1268,7 @@ int dev_queue_xmit(struct sk_buff *skb) 


	if (skb_shinfo(skb)->frag_list &&

	    !(dev->features & NETIF_F_FRAGLIST) &&

	    __skb_linearize(skb, GFP_ATOMIC))

	    __skb_linearize(skb))

		goto out_kfree_skb;



	/* Fragmented skb is linearized if device does not support SG,
@@ -1335,7 +1277,7 @@ int dev_queue_xmit(struct sk_buff *skb) 
	 */

	if (skb_shinfo(skb)->nr_frags &&

	    (!(dev->features & NETIF_F_SG) || illegal_highdma(dev, skb)) &&

	    __skb_linearize(skb, GFP_ATOMIC))

	    __skb_linearize(skb))

		goto out_kfree_skb;



	/* If packet is not checksummed and device does not support
@@ -3473,7 +3415,6 @@ subsys_initcall(net_dev_init); 
EXPORT_SYMBOL(__dev_get_by_index);

EXPORT_SYMBOL(__dev_get_by_name);

EXPORT_SYMBOL(__dev_remove_pack);

EXPORT_SYMBOL(__skb_linearize);

EXPORT_SYMBOL(dev_valid_name);

EXPORT_SYMBOL(dev_add_pack);

EXPORT_SYMBOL(dev_alloc_name);

CRA Git | Maintained and supported by SUSTech CRA and CCSE