debugfs: fix sparse warnings (3634634e) · Commits · 戴 / test

extern does not belong in C files, move declaration to linux/debugfs.h fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static? fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static? Signed-off-by:

Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

fs/debugfs/inode.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -29,10 +29,6 @@

		#define DEBUGFS_MAGIC 0x64626720

		/* declared over in file.c */
		extern struct file_operations debugfs_file_operations;
		extern struct inode_operations debugfs_link_operations;

		static struct vfsmount *debugfs_mount;
		static int debugfs_mount_count;

include/linux/debugfs.h

+5 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper {
		};

		#if defined(CONFIG_DEBUG_FS)

		/* declared over in file.c */
		extern const struct file_operations debugfs_file_operations;
		extern const struct inode_operations debugfs_link_operations;

		struct dentry debugfs_create_file(const char name, mode_t mode,
		struct dentry parent, void data,
		const struct file_operations *fops);

Admin message