Commit 3622adb0 authored Aug 24, 2020 by Tobias Klauser Committed by David S. Miller Aug 24, 2020

ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype



Commit 32927393 ("sysctl: pass kernel pointers to ->proc_handler")
changed ndisc_ifinfo_sysctl_change to take a kernel pointer. Adjust its
prototype in net/ndisc.h as well to fix the following sparse warning:

net/ipv6/ndisc.c:1838:5: error: symbol 'ndisc_ifinfo_sysctl_change' redeclared with different type (incompatible argument 3 (different address spaces)):
net/ipv6/ndisc.c:1838:5:    int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... )
net/ipv6/ndisc.c: note: in included file (through include/net/ipv6.h):
./include/net/ndisc.h:496:5: note: previously declared as:
./include/net/ndisc.h:496:5:    int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... )
net/ipv6/ndisc.c: note: in included file (through include/net/ip6_route.h):

Fixes: 32927393 ("sysctl: pass kernel pointers to ->proc_handler")
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a26aea20

include/net/ndisc.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -494,7 +494,7 @@ int igmp6_event_report(struct sk_buff *skb);

		#ifdef CONFIG_SYSCTL
		int ndisc_ifinfo_sysctl_change(struct ctl_table *ctl, int write,
		void __user buffer, size_t lenp, loff_t *ppos);
		void buffer, size_t lenp, loff_t *ppos);
		int ndisc_ifinfo_sysctl_strategy(struct ctl_table *ctl,
		void __user oldval, size_t __user oldlenp,
		void __user *newval, size_t newlen);

Admin message