Commit 361943ad authored May 12, 2008 by Steven Rostedt Committed by Thomas Gleixner May 23, 2008

ftrace: irqs off smp_processor_id() fix



The irqsoff function tracer did a __get_cpu_var to determine
if it should trace the function or not. The problem is that
__get_cpu_var can preempt between getting the CPU and reading
the cpu variable. This means that the cpu variable that is
being read is not from the cpu being run on.

At worst, this can give a false positive, where we trace the
function when we should not.  It will never give a false negative
since we only want to trace when interrupts are disabled
and we never preempt when they are.

This fix adds a check after reading the irq flags to only
trace if the interrupts are actually disabled. It also changes
the reading of the cpu variable to use a raw_smp_processor_id
since we now don't care if we preempt. We still catch that fact.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 5568b139

kernel/trace/trace_irqsoff.c

+11 −2

Original line number	Diff line number	Diff line
		@@ -74,12 +74,21 @@ irqsoff_tracer_call(unsigned long ip, unsigned long parent_ip)
		long disabled;
		int cpu;

		if (likely(!__get_cpu_var(tracing_cpu)))
		/*
		* Does not matter if we preempt. We test the flags
		* afterward, to see if irqs are disabled or not.
		* If we preempt and get a false positive, the flags
		* test will fail.
		*/
		cpu = raw_smp_processor_id();
		if (likely(!per_cpu(tracing_cpu, cpu)))
		return;

		local_save_flags(flags);
		/* slight chance to get a false positive on tracing_cpu */
		if (!irqs_disabled_flags(flags))
		return;

		cpu = raw_smp_processor_id();
		data = tr->data[cpu];
		disabled = atomic_inc_return(&data->disabled);

Admin message