Commit 3618bbaa authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Rafael J. Wysocki
Browse files

PM: runtime: Make clear what we do when conditions are wrong in rpm_suspend() 



rpm_suspend() simple bails out when conditions are wrong. But this is not
immediately obvious from the code.  Make it clear what we do when conditions
are wrong in rpm_suspend().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9cb1fd0e

drivers/base/power/runtime.c

+2 −4
Original line number Diff line number Diff line
@@ -523,13 +523,11 @@ static int rpm_suspend(struct device *dev, int rpmflags) 


 repeat:

	retval = rpm_check_suspend_allowed(dev);



	if (retval < 0)

		;	/* Conditions are wrong. */

		goto out;	/* Conditions are wrong. */



	/* Synchronous suspends are not allowed in the RPM_RESUMING state. */

	else if (dev->power.runtime_status == RPM_RESUMING &&

	    !(rpmflags & RPM_ASYNC))

	if (dev->power.runtime_status == RPM_RESUMING && !(rpmflags & RPM_ASYNC))

		retval = -EAGAIN;

	if (retval)

		goto out;

CRA Git | Maintained and supported by SUSTech CRA and CCSE