Commit 36148c2b authored Feb 02, 2018 by Toke Høiland-Jørgensen Committed by Johannes Berg Feb 23, 2018

mac80211: Adjust TSQ pacing shift



Since we now have the convenient helper to do so, actually adjust the
TSQ pacing shift for packets going out over a WiFi interface. This
significantly improves throughput for locally-originated TCP
connections. The default pacing shift of 10 corresponds to ~1ms of
queued packet data. Adjusting this to a shift of 8 (i.e. ~4ms) improves
1-hop throughput for ath9k by a factor of 3, whereas increasing it more
has diminishing returns.

Achieved throughput for different values of sk_pacing_shift (average of
5 iterations of 10-sec netperf runs to a host on the other side of the
WiFi hop):

sk_pacing_shift 10:  43.21 Mbps (pre-patch)
sk_pacing_shift  9:  78.17 Mbps
sk_pacing_shift  8: 123.94 Mbps
sk_pacing_shift  7: 128.31 Mbps

Latency for competing flows increases from ~3 ms to ~10 ms with this
change. This is about the same magnitude of queueing latency induced by
flows that are not originated on the WiFi device itself (and so are not
limited by TSQ).

Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 93c62c45

net/mac80211/tx.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -3574,6 +3574,14 @@ void __ieee80211_subif_start_xmit(struct sk_buff *skb,
		if (!IS_ERR_OR_NULL(sta)) {
		struct ieee80211_fast_tx *fast_tx;

		/* We need a bit of data queued to build aggregates properly, so
		* instruct the TCP stack to allow more than a single ms of data
		* to be queued in the stack. The value is a bit-shift of 1
		* second, so 8 is ~4ms of queued data. Only affects local TCP
		* sockets.
		*/
		sk_pacing_shift_update(skb->sk, 8);

		fast_tx = rcu_dereference(sta->fast_tx);

		if (fast_tx &&

Admin message