Commit 3612b87d authored Feb 26, 2019 by Gustavo A. R. Silva Committed by Wim Van Sebroeck Mar 02, 2019

watchdog: sbc60xxwdt: Mark expected switch fall-through



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/watchdog/sbc60xxwdt.c: In function ‘fop_ioctl’:
drivers/watchdog/sbc60xxwdt.c:272:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   wdt_keepalive();
   ^~~~~~~~~~~~~~~
drivers/watchdog/sbc60xxwdt.c:275:2: note: here
  case WDIOC_GETTIMEOUT:
  ^~~~

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

parent 4a1b1161

drivers/watchdog/sbc60xxwdt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -270,8 +270,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)

		timeout = new_timeout;
		wdt_keepalive();
		/* Fall through */
		}
		/* Fall through */
		case WDIOC_GETTIMEOUT:
		return put_user(timeout, p);
		default:

Admin message