Commit 35e396cd authored Aug 22, 2008 by xiphmont@xiph.org Committed by Jens Axboe Oct 09, 2008

SG_IO block filter whitelist missing MMC SET READ AHEAD command



I have another request for the block filter SG_IO command whitelist,
specifically the MMC streaming command set SET READ AHEAD command.
The command applies only to MMC CDROM/DVDROM drives with the streaming
optional feature set.  The command is useful to cdparanoia in that it
allows explicit cache control side effects that are, on many drives,
cdparanoia's most efficient way to flush/disable the media cache on
cdrom drives. I am aware of no reason why it should not be accessible
from usespace.

Also note that the command is already fully accessible through the
SCSI-native version of the SG_IO ioctl as well as the traditional SG
interface.  The command is only being refused on block devices.  That
means that on a typical stock distro, the command is available through
/dev/sg* but not /dev/scd* although both are typically available and
accessible.  Filtering the command is not providing any protection,
only a confusing inconsistency.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent 69849375

block/scsi_ioctl.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -185,6 +185,7 @@ void blk_set_cmd_filter_defaults(struct blk_cmd_filter *filter)
		__set_bit(GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL, filter->write_ok);
		__set_bit(GPCMD_LOAD_UNLOAD, filter->write_ok);
		__set_bit(GPCMD_SET_STREAMING, filter->write_ok);
		__set_bit(GPCMD_SET_READ_AHEAD, filter->write_ok);
		}
		EXPORT_SYMBOL_GPL(blk_set_cmd_filter_defaults);

Admin message