Commit 35e00da3 authored Nov 03, 2017 by Eric Dumazet Committed by David S. Miller Nov 05, 2017

tcp: do not clear again skb->csum in tcp_init_nondata_skb()



tcp_init_nondata_skb() is fed with freshly allocated skbs.
They already have a cleared csum field, no need to clear it again.

This is based on Neal review on commit 3b117750 ("tcp: do not mangle
skb->cb[] in tcp_make_synack()"), noticing I did not clear skb->csum.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d0f36847

net/ipv4/tcp_output.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -381,7 +381,6 @@ static void tcp_ecn_send(struct sock sk, struct sk_buff skb,
		static void tcp_init_nondata_skb(struct sk_buff *skb, u32 seq, u8 flags)
		{
		skb->ip_summed = CHECKSUM_PARTIAL;
		skb->csum = 0;

		TCP_SKB_CB(skb)->tcp_flags = flags;
		TCP_SKB_CB(skb)->sacked = 0;

Admin message