Commit 35d8c7ad authored Oct 31, 2011 by Hillf Danton Committed by Linus Torvalds Oct 31, 2011

mm/huge_memory: fix typo when updating mmu cache



There are three cases of update_mmu_cache() in the file, and the case in
function collapse_huge_page() has a typo, namely the last parameter used,
which is corrected based on the other two cases.

Due to the define of update_mmu_cache by X86, the only arch that
implements THP currently, the change here has no really crystal point, but
one or two minutes of efforts could be saved for those archs that are
likely to support THP in future.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0089e485

mm/huge_memory.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1952,7 +1952,7 @@ static void collapse_huge_page(struct mm_struct *mm,
		BUG_ON(!pmd_none(*pmd));
		page_add_new_anon_rmap(new_page, vma, address);
		set_pmd_at(mm, address, pmd, _pmd);
		update_mmu_cache(vma, address, entry);
		update_mmu_cache(vma, address, _pmd);
		prepare_pmd_huge_pte(pgtable, mm);
		mm->nr_ptes--;
		spin_unlock(&mm->page_table_lock);

Admin message