Commit 35d1a405 authored by Xiaoliang Pang's avatar Xiaoliang Pang Committed by Alex Deucher
Browse files

drm/amdgpu/powerplay: hwmgr - modify the return value 



Return value should be -EINVAL rather than EINVAL

Fixes: f83a9991("drm/amd/powerplay: add Vega10 powerplay support (v5)")
Fixes: 2cac05de("drm/amd/powerplay: add the hw manager for vega12 (v4)")
Cc: Eric Huang <JinHuiEric.Huang@amd.com>
Cc: Evan Quan <evan.quan@amd.com>
Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Acked-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarXiaoliang Pang <dawning.pang@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 71f49c48

drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c

+1 −1
Original line number Diff line number Diff line
@@ -4659,7 +4659,7 @@ static int vega10_display_configuration_changed_task(struct pp_hwmgr *hwmgr) 
	if ((data->water_marks_bitmap & WaterMarksExist) &&

			!(data->water_marks_bitmap & WaterMarksLoaded)) {

		result = smum_smc_table_manager(hwmgr, (uint8_t *)wm_table, WMTABLE, false);

		PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);

		PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);

		data->water_marks_bitmap |= WaterMarksLoaded;

	}

drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c

+1 −1
Original line number Diff line number Diff line
@@ -2444,7 +2444,7 @@ static int vega12_display_configuration_changed_task(struct pp_hwmgr *hwmgr) 
			!(data->water_marks_bitmap & WaterMarksLoaded)) {

		result = smum_smc_table_manager(hwmgr,

						(uint8_t *)wm_table, TABLE_WATERMARKS, false);

		PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);

		PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);

		data->water_marks_bitmap |= WaterMarksLoaded;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE