Commit 35bb4b22 authored Apr 17, 2020 by Douglas Anderson Committed by Bjorn Andersson Apr 20, 2020

soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner

Adding an item into the cache should never be able to make the cache
cleaner. Use "|=" rather than "=" to update the dirty flag.

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Maulik Shah <mkshah@codeaurora.org> Thanks, Maulik
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Fixes: bb700067 ("soc: qcom: rpmh: Update dirty flag only when data changes")
Reported-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200417141531.1.Ia4b74158497213eabad7c3d474c50bfccb3f342e@changeid

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 64016bb8

drivers/soc/qcom/rpmh.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -151,7 +151,7 @@ existing:
		break;
		}

		ctrlr->dirty = (req->sleep_val != old_sleep_val \|\|
		ctrlr->dirty \|= (req->sleep_val != old_sleep_val \|\|
		req->wake_val != old_wake_val) &&
		req->sleep_val != UINT_MAX &&
		req->wake_val != UINT_MAX;