Commit 35acfbab authored by Li RongQing's avatar Li RongQing Committed by Pablo Neira Ayuso
Browse files

netfilter: remove unneeded switch fall-through 



Empty case is fine and does not switch fall-through

Signed-off-by: default avatarLi RongQing <lirongqing@baidu.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent cc169213

net/netfilter/nf_nat_core.c

+1 −1
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ static bool l4proto_in_range(const struct nf_conntrack_tuple *tuple, 
	__be16 port;



	switch (tuple->dst.protonum) {

	case IPPROTO_ICMP: /* fallthrough */

	case IPPROTO_ICMP:

	case IPPROTO_ICMPV6:

		return ntohs(tuple->src.u.icmp.id) >= ntohs(min->icmp.id) &&

		       ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id);

net/netfilter/nf_tables_core.c

+0 −1
Original line number Diff line number Diff line
@@ -221,7 +221,6 @@ next_rule: 
		chain = regs.verdict.chain;

		goto do_chain;

	case NFT_CONTINUE:

		/* fall through */

	case NFT_RETURN:

		nft_trace_packet(&info, chain, rule,

				 NFT_TRACETYPE_RETURN);

CRA Git | Maintained and supported by SUSTech CRA and CCSE